Amir Plivatsky

Results 369 comments of Amir Plivatsky

> Off-topic: for me, having some of the `Parse_Opts` be `#defines` in the dict would solve some of my problems. This includes `!limit` and `!timeout` ... and maybe also `islands_ok`...

I have not yet commented on some things you mentioned: Regarding the possible earlier release of `mlc_pool`, `mk_parse_set()` uses it, so its release would free working memory at the expense...

Sharing this one: ``` c struct Parse_choice_lr { Parse_set * set; Disjunct *md; /* the chosen disjunct for the middle word */ int32_t id; /* the tracon (l_id for l_pc...

> The `Connector *le, *re;` are in the `Parse_set`. I'm guessing wildly that they are connectors on `Parse_set_struct::lw` and `rw`? If so, can they be removed and replaced by `get_tracon(Parse_set_struct::l_id)`...

> I guess we can leave this alone for now. Things are complicated enough, as it is. But the opposite thing, i.e. remove `int32_t l_id, r_id;` seems easy and without...

> The `Connector *le, *re;` are in the `Parse_set`. I'm guessing wildly that they are connectors on `Parse_set_struct::lw` and `rw`? If so, can they be removed and replaced by `get_tracon(Parse_set_struct::l_id)`...

> it seems possible to also get rid of Disjunct *md I Could not do it after all.

For 6.00 I have many PRs that I would like to include at least some of them: 1. Dict token insertion (need to find the issue number). 2. Tokenization drastic...

> Option 2 seems clearer. I will send the PR tomorrow. > Can we close #1352 after this? Yes.

IT seems I answered in the wrong box and pressed the wrong button! Hopefully, no damage has resulted...