Amir Plivatsky
Amir Plivatsky
Regarding a dict `default-max-disjunct-cost` definition, I propose to add both of `linkgrammar_get_dict_max_disjunct_cost()` and `linkgrammar_set_dict_max_disjunct_cost()`, and in the same time NOT to make `parse_options_set_disjunct_cost()` a no-op. This way this addition would...
> So I guess that `Parse_options` will store a default max cost of -10000. Then, during parsing, if `Parse_options->cost > -1000` then that value will be used; otherwise the value...
Implementation questions: 1. I noted that dict definitions are randomly done in both `dict-common.h` and `dict-defines.h`. I think most, if not all, should be moved to `dict-defines.h`. In any case,...
> either `#define DEFAULT_MAX_COST -10000` or (better yet) `static const int DEFAULT_MAX_COST = -10000;`. I propose to call it `UNINITIALIZED_MAX_COST`.
In case you would like me to change something (of course I can also make changes after I submit the PR), here is what I defined: In `dict-defines.h`: ``` c...
I made some changes. 1. In the dict I used `-` instead of `_`: `#define default-max-disjunct-cost 2.7` 2, In `.h` I added: static char DEFAULT_MAX_COST_DEFNAME[] = "default-max-disjunct-cost";
Above, I said: > BTW, isn't 4.0 too high for panic parsing, as it allows headlines? Also, panic is about parse time, not an inability to produce a full parse....
@linas, I finished the dict `#define` library implementation and dict conversion. I will need your input regarding my naming concerns (mentioned above) to make fixes if needed.
> Above, I said: > > > BTW, isn't 4.0 too high for panic parsing, as it allows headlines? Also, panic is about parse time, not an inability to produce...
Is there any other benefit for doing such a change, besides being more "sane"? BTW, rewriting the SAT-parser way of handling expressions is also in my list, so if I...