training icon indicating copy to clipboard operation
training copied to clipboard

scala bigrams exercise

Open jowens opened this issue 11 years ago • 1 comments

"output a set of all “word1_word2” pairs that occur in sequence in the input string"

I don't like "in sequence". If you use Set, they won't be in sequence. I would remove "in sequence".

Also, I'd give the prototype for the function (makes it easier on new Scala users).

jowens avatar Aug 30 '13 18:08 jowens

Hi John,

These are good points -- thanks for the feedback!

-Ameet

On Fri, Aug 30, 2013 at 11:59 AM, John Owens [email protected]:

"output a set of all “word1_word2” pairs that occur in sequence in the input string"

I don't like "in sequence". If you use Set, they won't be in sequence. I would remove "in sequence".

Also, I'd give the prototype for the function (makes it easier on new Scala users).

— Reply to this email directly or view it on GitHubhttps://github.com/amplab/training/issues/101 .

atalwalkar avatar Aug 30 '13 21:08 atalwalkar