succinct
succinct copied to clipboard
amplab
WIP: Add support for Array-Type in JSON
@anuragkh PR is currently WIP, but wanted to check if the approach was alright
Hi @muditsin, thanks for contributing!
The approach looks about right to me, although there is some code duplication (e.g., parsing the values in the array is the same as parsing individual values). Perhaps making them modular might help reduce code redundancy.
Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/Succinct-PRB/3/
Build result: FAILURE
[...truncated 216 lines...][INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project succinct-serde: Compilation failure[ERROR] /home/jenkins/workspace/Succinct-PRB/serde/src/main/java/edu/berkeley/cs/succinct/object/deserializer/JsonDeserializer.java:[119,54] error: ';' expected[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn
@muditsin, Jenkins is only triggered by repo admins and whitelisted committers atm. I'll add you to whitelist.
Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/Succinct-PRB/4/ Test PASSed.
Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/Succinct-PRB/5/ Test PASSed.