keystone icon indicating copy to clipboard operation
keystone copied to clipboard

Make all nodes case classes or have companion object constructor

Open tomerk opened this issue 9 years ago • 1 comments

Discussion with @etrain suggests that we should be very consistent about how nodes are constructed.

Because:

  • @etrain doesn't like new
  • including empty parens in some cases (case classes w/ default parameters) and not others (objects) is inconsistent

The plan is to have all nodes either be case classes, or have a companion object constructor

tomerk avatar May 18 '15 19:05 tomerk

To be fair - I have no problem with new - it's just a dislike for boilerplate.

Guidelines about where and when to use objects vs. case classes could also go in a style guide. #113

etrain avatar May 18 '15 20:05 etrain