http-server-router icon indicating copy to clipboard operation
http-server-router copied to clipboard

Do not decode path before matching

Open trowski opened this issue 1 year ago • 0 comments

This reverts #4. I believe https://datatracker.ietf.org/doc/html/rfc3986.html#section-2.4 was mis-interpreted. We should not be decoding the path until after matching, otherwise "/" is interpreted as separating path segments.

Matched route parameters set in attributes are decoded. This is similar to our handling of query parameters, which are also decoded before returning from Request::getQueryParameter(), etc.

See https://chat.stackoverflow.com/transcript/message/57474623#57474623.

This is a BC break and will require a new major, since routes will need to be defined using the URL encoded version. I don't anticipate this would affect many users.

trowski avatar Jul 04 '24 15:07 trowski