proselint
proselint copied to clipboard
make checks individual
This relates to...
The structure of checks directories.
Related issues:
- Follows on from #951.
- This resolves #729.
- This resolves #491.
- This resolves #1091.
Rationale
At present, some subcheck files (e.g. typography.symbols
, redundancy.misc
)
contain multiple subchecks. This is an illogical structure, prevents disabling
the subchecks in .proselintrc
which should be possible, et cetera. This PR
fixes that by moving them into individual subcheck files, where they belong.
Changes
N/A (WIP).
Features
N/A.
Bug Fixes
N/A.
Breaking Changes and Deprecations
N/A.
Codecov Report
Merging #1172 (281e88c) into main (ae2161b) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head 281e88c differs from pull request most recent head 0b992d5. Consider uploading reports for the commit 0b992d5 to get more accurate results
@@ Coverage Diff @@
## main #1172 +/- ##
=======================================
Coverage 90.19% 90.19%
=======================================
Files 83 83
Lines 1203 1203
=======================================
Hits 1085 1085
Misses 118 118
Flag | Coverage Δ | |
---|---|---|
macos-latest | 90.19% <0.00%> (ø) |
|
py3.6 | 89.22% <0.00%> (ø) |
|
py3.7 | 89.22% <0.00%> (ø) |
|
py3.8 | 90.19% <0.00%> (ø) |
|
py3.9 | 90.19% <0.00%> (ø) |
|
pypypy3 | 89.22% <0.00%> (ø) |
|
ubuntu-latest | 90.19% <0.00%> (ø) |
|
windows-latest | 90.19% <0.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ae2161b...0b992d5. Read the comment docs.
As an update, I think it would be better to make a plan for recategorising things before actually implementing the changes. Ideally, there will be some kind of framework as to what kind of checks are supported and determining where they belong.
Categories
nytelife26@[Elysian] » ls | where type == dir | skip | get name
╭────┬───────────────────╮
│ 0 │ airlinese │
│ 1 │ annotations │
│ 2 │ archaism │
│ 3 │ cliches │
│ 4 │ consistency │
│ 5 │ corporate_speak │
│ 6 │ cursing │
│ 7 │ dates_times │
│ 8 │ hedging │
│ 9 │ hyperbole │
│ 10 │ inprogress │
│ 11 │ jargon │
│ 12 │ lexical_illusions │
│ 13 │ lgbtq │
│ 14 │ links │
│ 15 │ malapropisms │
│ 16 │ misc │
│ 17 │ mixed_metaphors │
│ 18 │ mondegreens │
│ 19 │ needless_variants │
│ 20 │ nonwords │
│ 21 │ oxymorons │
│ 22 │ psychology │
│ 23 │ redundancy │
│ 24 │ security │
│ 25 │ sexism │
│ 26 │ skunked_terms │
│ 27 │ spelling │
│ 28 │ terms │
│ 29 │ typography │
│ 30 │ uncomparables │
│ 31 │ weasel_words │
╰────┴───────────────────╯
Squash
airlinese
and corporate_speak
into simply corporate_speak
.
sexism
and lgbtq
into societal
(? title WIP).
Uncertain
I think a lot of the content of cursing
is somewhat beyond our scope. People only ever write those things when they mean to, and there are too many vulgar words around for us to accurately capture them.