aces-dev icon indicating copy to clipboard operation
aces-dev copied to clipboard

Add LogC4 to CSC

Open nick-shaw opened this issue 11 months ago • 5 comments

ARRI LogC4 has been added to the IDTs, but not to the CSCs. This PR adds it to the CSCs as well, for completeness.

nick-shaw avatar Aug 02 '23 16:08 nick-shaw

@scoopxyz it would be good to get your eyes on this.

The LogC4 to ACES is pretty much a copy of the IDT, except it uses the same CTL calculate_rgb_to_rgb_matrix function that the other CSCs use, rather than declaring matrix values in the code. The other is the same, but edited to invert things.

nick-shaw avatar Aug 02 '23 22:08 nick-shaw

In my testing, the use of calculate_rgb_to_rgb_matrix means that there are some very small differences in the lower decimal places between using the IDT and the CSC. But this is the case with all the CSCs. Arguably all the IDTs should use that same function too, so as not to limit the matrix to varying arbitrary precision, as the different manufacturer IDTs do.

nick-shaw avatar Aug 04 '23 10:08 nick-shaw

Hi all,

We're currently facing this same thing on a project we're running right now and would love to see this get through

Thanks, Josh

JoshkVFX avatar Aug 09 '23 07:08 JoshkVFX

Hi Nick, just acknowledging that I've seen this but haven't had the time to validate it myself. It sounds logical to continue using the derivation of matrices in the same fashion as the the other CSC spaces.

scoopxyz avatar Sep 18 '23 19:09 scoopxyz