Alexander Motin

Results 260 comments of Alexander Motin

@ryantrinkle I am not sure why would `rsync` request sync writes. But if it really does, and if your storage is very slow comparing to the amount of RAM, you...

@RubenKelevra Closing file does not have an `fsync()` semantics, otherwise copying zillion of tiny files with `cp` to HDD pool would be a disaster. If as you are saying that...

I can just answer with chunks of ZFS `close()` code: ``` static int zpl_release(struct inode *ip, struct file *filp) { cred_t *cr = CRED(); int error; fstrans_cookie_t cookie; cookie =...

``` [] __cv_timedwait_common+0x12d/0x170 [spl] [] __cv_timedwait_io+0x15/0x20 [spl] [] zio_wait+0x130/0x290 [zfs] [] dmu_buf_hold+0x5f/0x90 [zfs] [] zap_lockdir+0x4e/0xc0 [zfs] ``` Looks like it is waiting for some disk read, but can't say why...

I am not really familiar with project quotas, so while from one side proposed solution kind of makes sense, from another I wonder what is the expected behavior for the...

@jsai20 I don't like the concept that objects created before upgrade are counted as ZFS_INVALID_PROJID, while after upgrade as project 0. It makes project 0 accounting useless, if it was...

> Let me also check bit more on correctly upgrading old objects to project 0. Purely theoretical, I guess it might be not updating the objects, but just accounting them....

@jsai20 It does not build on FreeBSD: ``` /home/zfs/zfs/module/zfs/dmu_objset.c:2530:26: error: no member named 'comm' in 'struct thread' 2530 | __func__, current->comm, current->pid, name); | ~~~~~~~ ^ /home/zfs/zfs/module/zfs/dmu_objset.c:2530:41: error: no member...

> Updated new patch Replacing "current->comm" with getcomm() and "current->pid()" with getpid(). The building seems going better now, but why do you think these messages are useful enough to be...

@grahamperrin I haven't looked on this thread, but I don't think so. That fix was not for a leak, but to a short-time race. And the issue it fixed was...