TodoList icon indicating copy to clipboard operation
TodoList copied to clipboard

Unit tests todoItemService

Open reerden opened this issue 4 years ago • 5 comments

Issue #1

Added unittests for TodoItemService.AddItemAsync() using Entity Framework Core InMemory database.

reerden avatar Oct 01 '19 19:10 reerden

Codecov Report

Merging #31 into develop will increase coverage by 8.36%. The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
+ Coverage    21.86%   30.23%   +8.36%     
===========================================
  Files           94       87       -7     
  Lines         3457     2550     -907     
===========================================
+ Hits           756      771      +15     
+ Misses        2701     1779     -922
Impacted Files Coverage Δ
TodoList.Web/Data/ApplicationDbContext.cs 70% <40%> (+70%) :arrow_up:
TodoList.Web/Views/Home/Contact.cshtml 0% <0%> (ø) :arrow_up:
TodoList.Web/Startup.cs 0% <0%> (ø) :arrow_up:
...ta/Migrations/ApplicationDbContextModelSnapshot.cs 0% <0%> (ø) :arrow_up:
TodoList.Web/Views/Shared/_Layout.cshtml 0% <0%> (ø) :arrow_up:
TodoList.Web/Views/Todos/Home.cshtml 0% <0%> (ø) :arrow_up:
TodoList.Web/Views/Todos/Index.cshtml 0% <0%> (ø) :arrow_up:
TodoList.Web/Views/Todos/Create.cshtml 0% <0%> (ø) :arrow_up:
TodoList.Web/Views/Todos/Details.cshtml 0% <0%> (ø) :arrow_up:
TodoList.Web/Models/EditViewModel.cs 100% <0%> (ø) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ad138a...e5354c7. Read the comment docs.

codecov-io avatar Oct 01 '19 19:10 codecov-io

I am going to keep this PR open. I would like the whole interface in one commit.

Thanks for contributing to the project.

amoraitis avatar Oct 03 '19 17:10 amoraitis

I'll try to add some more tests in this PR soon 😃

reerden avatar Oct 03 '19 18:10 reerden

@reerden What's the status of this one? Can we please resolve this?

amoraitis avatar Oct 30 '19 07:10 amoraitis

Codecov Report

Merging #31 into develop will increase coverage by 1.60%. The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
+ Coverage    28.63%   30.23%   +1.60%     
===========================================
  Files           87       87              
  Lines         2546     2550       +4     
===========================================
+ Hits           729      771      +42     
+ Misses        1817     1779      -38     
Impacted Files Coverage Δ
TodoList.Web/Data/ApplicationDbContext.cs 70.00% <40.00%> (+70.00%) :arrow_up:
TodoList.Web/Services/TodoItemService.cs 21.05% <0.00%> (+21.05%) :arrow_up:
TodoList.Web/Models/TodoItem.cs 100.00% <0.00%> (+53.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00e73e1...e5354c7. Read the comment docs.

codecov-commenter avatar Sep 22 '20 19:09 codecov-commenter