TodoList icon indicating copy to clipboard operation
TodoList copied to clipboard

Published 20 hours ago • verified publisher icon amoraitis

Unit testing

Open amoraitis opened this issue 7 years ago • 12 comments

**Is your feature request related to a problem?

We need unit tests to cover the project with. Currently covered codecov

amoraitis avatar Oct 23 '18 15:10 amoraitis

Hi buddy, I like your project, looks very nice indeed 👌

I would like to contribute to it, especially in this particular issue (which is testing coverage).

I have a little question about it, I cloned the project and when I tried to run it, just exploded 😅

I'm using an Ubuntu 16.04 based Linux distribution and I got the following error after logging in:

PlatformNotSupportedException: LocalDB is not supported on this Platform.

Does that mean that the app doesn't run on Linux? The answer looks pretty obvious to me, it would be nice adding Linux support, Thanks to .NET Core should be easy peasy.

maxalmonte14 avatar Oct 26 '18 18:10 maxalmonte14

@maxalmonte14 Temporary solution: I think that you can use InMemoryDatabase for linux without adding it to Version Control.

I will, also, move to sqlite on the next commit

amoraitis avatar Oct 27 '18 07:10 amoraitis

Great, I'll try to implement this solution, and then add some tests :v:

maxalmonte14 avatar Oct 27 '18 13:10 maxalmonte14

I'm still on this, I'm having a hard time trying to test async methods, also trying to mock dependencies like DbContext, I have to get use to C# testing tools, but eventually I will make a PR. ✌️

maxalmonte14 avatar Nov 01 '18 21:11 maxalmonte14

@maxalmonte14 please use docs. Start with this one

amoraitis avatar Nov 02 '18 11:11 amoraitis

I created a PR :) #31

reerden avatar Oct 01 '19 19:10 reerden

Thank so much for your contribution @RemcoE, I will review in the next 1 or 2 days.

amoraitis avatar Oct 01 '19 19:10 amoraitis

Hi, do you still need help with this?

jezmaghuyop avatar Oct 16 '19 13:10 jezmaghuyop

@jezmaghuyop This will remain open, we always want better test coverage for the project.

So, feel free to add you tests.

amoraitis avatar Oct 16 '19 17:10 amoraitis

Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?

abc516 avatar Oct 15 '20 20:10 abc516

Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?

Hi, please check for areas not covered yet. I am pretty sure that the TodoItemService is not covered.

amoraitis avatar Oct 15 '20 20:10 amoraitis

Hi @amoraitis. Will you please assign this issue to me? I am using #hacktoberfest to get into the OSS community. I think this is a great task for me to work on. BTW, can you also create an issue item to port the code to dot net 7? If you create that issue, you can assign that one to me too. Thanks!

pdelcogliano avatar Oct 12 '23 22:10 pdelcogliano