Alexis Montoison

Results 300 comments of Alexis Montoison

@zaikunzhang It seems that you don't need to do something. Only `prima.h` is installed: https://github.com/libprima/prima/blob/main/c/CMakeLists.txt#L32

@zaikunzhang We have new errors on Windows with the Intel compilers. All tests passed on the other platforms.

> Thank you @amontoison . The errors complain that some function is deprecated and suggest a replacement. It seems easy to fix, right? Thanks. For the issue with deprecated routine,...

> https://github.com/amontoison/prima/blob/c_headers_internal/c/tests/stress.c#L10 > > ```c > // Make PRIMA available > #include "prima/prima_internal.h" > ``` > > Shouldn't we use `prima.h` instead of `prima_internal.h` here? You need the header of...

> Hi @amontoison , > > > For the issue with deprecated routine, we can use the preprocessed macro _WIN32 to check if we are on Windows. > > ```c...

> Hi @amontoison , > > I wanted to try fixing other warnings but did not know how to do it cleanly on top of your PR, so I created...

Hi @zaikunzhang! The issue is that you have some headers of C functions in `prima.c`. They should in a `*.h` file. I suppose that they are not in `prima.h` because...

> > Why do we use pointers here for `problem` and `options`? > > Because passing them by value is not necessary and is a waste of stack space. It...

On Windows, we need an import library (.lib) if we want to compile with MSVC. Some cross-compilers like MinGW are smart enough to not require it. I suggest to try...

I confirm that you need CUDA.allowscalar(false) to test that the code is working correctly on GPU.