PRIME-augmentations icon indicating copy to clipboard operation
PRIME-augmentations copied to clipboard

Port to Kornia

Open shijianjian opened this issue 2 years ago • 2 comments

Hi @amodas , just encountered your paper and it appears to be a very interesting augmentation.

I am wondering if you are interested in porting this code into Kornia? We are the maintainers of that project and hope to have this feature.

Let me know if anything!

/cc @edgarriba @ducha-aiki

shijianjian avatar Mar 20 '22 17:03 shijianjian

Hi @shijianjian! We would be more than happy to have our method as part of Kornia! What is the typical process for making this happen?

amodas avatar Mar 22 '22 16:03 amodas

@amodas Great. We have recently adapted another similar work, that is very similar procedures as this one I believe. You may refer to https://github.com/kornia/kornia/blob/master/kornia/augmentation/_2d/intensity/planckian_jitter.py

Basically, we need the main function as well as a random generator like this https://github.com/kornia/kornia/blob/5dc3c71a5385aa1cdebb39b7aa4f47a0663c9661/kornia/augmentation/random_generator/_2d/planckian_jitter.py

Shouldn't be complicated by looking through your code. I would suggest filing a quick PR then we may iterate on it.

shijianjian avatar Mar 23 '22 15:03 shijianjian