Ashok Menon

Results 158 comments of Ashok Menon

I believe @tnowacki is looking into making the transactional tests work with the in-memory store, FWIW.

(The change to introduce the new Session API is otherwise good though)

> I assume we cannot just create a new VM on-the-fly for the conservation check? We can do this, but then it may involve doing a lot of extra work...

It does, but it will entirely replicate that inside the VM, multiple times over.

Thanks for the review @damirka ! Just going to address the style comments now. > That's a lot of code and looks cool! On this, I was considering splitting this...

Pushed an almost complete rewrite of the demo. Now, instead of demonstrating shared/permissioned access to a game between the game admin/service and the player, we are demonstrating a game that...

Hi @josemvcerqueira, have you seen the `coin::mint_for_testing` and `balance::create_for_testing` helpers? They allow you to create coins and balances for any coin type in the test environment: https://github.com/MystenLabs/sui/blob/473e4e25615fb47cd788aaba849a372189df52bc/crates/sui-framework/packages/sui-framework/sources/coin.move#L409-L413 https://github.com/MystenLabs/sui/blob/473e4e25615fb47cd788aaba849a372189df52bc/crates/sui-framework/packages/sui-framework/sources/balance.move#L118-L122

@damirka / @tzakian / @tnowacki, could you double check for me that this seems okay? It looks fine to me, and is serving a niche that I can't think of...

> I think I can update Event representation to have optional StoredEvent and required NativeSuiEvent I was just having a look at this -- there are quite a few rows...

Thanks @wlmyng, some small clean-ups for this here: #15577