Ashok Menon

Results 158 comments of Ashok Menon

I've slightly lost the plot from this point on which bits are part of #5169 and which are new -- is there a way to get that info?

> When viewing the files, you can select the range of commits to view 🤦 yep, yep -- I had this as a shower thought this morning.

My 2c is to err on the side of being overly conservative now, and then relax over time, but given how conservative this will be, to work on those improvements...

> Agreed but thoughts on specifications here? So this is what the major version + hash of AST + hash of dependencies combination was supposed to cover (under an assumption...

Also, it's good that this PR has a test plan, but can we check in a test of some kind? **EDIT** just to clarify -- I see the test code...

I think it looks great! The only thing that gave me pause was `peel_vec_vec_u8` which seems like a slippery slope. I've left a comment there with some suggestions. Regarding `BCS`...

Note that I've answered a question about this on [Stack Overflow](https://stackoverflow.com/questions/73958046/local-dependency-cannot-be-resolved/73959597#73959597) which may be relevant.

@mystenmark, @andll and myself chatted a little bit more about the issue of reliably detecting stack overflow. On Tier 1 platforms (including x86_64) it does seem like `__rust_probestack` is doing...

Sam recently landed #5506 which makes it easier to configure when we get diagnostic information from `move` when called via `sui`. It's possible that a combination of enabling diagnostics with...

I'm pretty sure this is @sblackshear's change -- I recall that it changed the BuildConfig associated with `move build` to print diagnostics. If the build needs to pull stdlib or...