Ammar Bandukwala

Results 163 comments of Ammar Bandukwala

If we compress the log on capture, wouldn't that make it difficult / impossible to stream the log piecewise in the future?

Right now logs older than 30 days are getting deleted automatically, so I don't think we have to worry about storage. An upper-bounded workspace would generate 30MB of logs per...

I think the pull architecture is the way to go: * We can avoid PrefixSuffixWriter, always giving the user the full log * We can seek, efficiently serving massive logs...

I see the value in that. We could follow suit of `net/http` and have package-level methods that use a DefaultDNSClient but then give users the ability to specify their own....

Not sure. I'm not the maintainer. cc @robinlieb merged in my change.

See https://github.com/go-playground/webhooks/pull/173 Or you can add this to your `go.mod` to use it before merge: ``` replace github.com/go-playground/webhooks/v6 => github.com/ammario/webhooks/v6 v6.0.0-20230530210742-61c8d3560b68 ```

It also invariably improves output

I archived it. We still have some stragglers on v1, so will probably leave the repo around for a while.

We will almost certainly release Secrets w/o any hard requirement to use an external KMS or Vault but instead allow that as an option for increased security. It's hard to...