pyCraft icon indicating copy to clipboard operation
pyCraft copied to clipboard

1.19 support?

Open Anonymous941 opened this issue 3 years ago • 24 comments

Is this project going to have support for Minecraft 1.19 in the future?

Anonymous941 avatar Jul 06 '22 17:07 Anonymous941

I might work out some time to get 1.19 patch over the weekend when I have time.

MisterSoandSo avatar Jul 07 '22 19:07 MisterSoandSo

Thank you, I've been spending hours trying to find a way to mod that version.

Anonymous941 avatar Jul 07 '22 21:07 Anonymous941

Why closing this ? It might be good to have a feed to discuss 1.19 implementation and closing it once it is merged.

Nonoreve avatar Jul 08 '22 15:07 Nonoreve

No idea why they closed this quick as I barely looked at new protocol scheme. I said I'd work on the update but not a guarantee update in the next few days.

MisterSoandSo avatar Jul 08 '22 16:07 MisterSoandSo

yea this is not a trivial task

Nonoreve avatar Jul 09 '22 07:07 Nonoreve

No idea why they closed this quick as I barely looked at new protocol scheme. I said I'd work on the update but not a guarantee update in the next few days.

Sorry, I figured that you would implement it and there was no longer a need for this issue. I'll reopen it.

Anonymous941 avatar Jul 09 '22 14:07 Anonymous941

image One reason why 1.19 is annoying to update atm .... This is new chat message packet

MisterSoandSo avatar Jul 09 '22 15:07 MisterSoandSo

image Versus pre-1.18.2

MisterSoandSo avatar Jul 09 '22 15:07 MisterSoandSo

yea this is not a trivial task

I want to cry internally after looking at the changes for both client and serverside packets

MisterSoandSo avatar Jul 09 '22 17:07 MisterSoandSo

image One reason why 1.19 is annoying to update atm .... This is new chat message packet

Where is this picture from?

Anonymous941 avatar Jul 10 '22 00:07 Anonymous941

Where is this picture from? https://wiki.vg/Protocol

MisterSoandSo avatar Jul 10 '22 03:07 MisterSoandSo

image One reason why 1.19 is annoying to update atm .... This is new chat message packet

Here's a modified version of the ChatPacket. I'll work on patching the other classes if I have some time.

Anonymous941 avatar Jul 10 '22 12:07 Anonymous941

I've added support for a few more serverbound types. It seems that this version introduces a lot more types of packets.

Anonymous941 avatar Jul 10 '22 13:07 Anonymous941

I've added support for a few more serverbound types. It seems that this version introduces a lot more types of packets.

This might help ... https://github.com/MisterSoandSo/Minecraft-Packet-Protocol-Database

MisterSoandSo avatar Jul 10 '22 14:07 MisterSoandSo

I've patched a few more classes, but I'm not sure I currently have the time to patch them all. If anyone wants to help, I can make you a collaborator on the fork.

Anonymous941 avatar Jul 12 '22 12:07 Anonymous941

progress?

sequoiadotdev avatar Jul 29 '22 20:07 sequoiadotdev

Bit busy IRL. This update has slowed down on my end.

MisterSoandSo avatar Jul 30 '22 00:07 MisterSoandSo

Will there be any difference between 1.19 and 1.19.1? As far as I can tell, they just added reporting.

Anonymous941 avatar Aug 01 '22 12:08 Anonymous941

the protocol changed, so yes.

MiniDigger avatar Aug 01 '22 16:08 MiniDigger

At this point I believe 1.19+ warrants complete overhaul as

  1. Mojang auth is depreciated. You need to the Microsoft/xbox login ... Doable but not published in pycraft
  2. Chat packet is needs revamping
  3. Proposal: A better updating scheme for packet number as this affects maintainability in the long run

MisterSoandSo avatar Aug 01 '22 16:08 MisterSoandSo

At this point I believe 1.19+ warrants complete overhaul as

1. Mojang auth is depreciated. You need to the Microsoft/xbox login ... Doable but not published in pycraft

2. Chat packet is needs revamping

3. Proposal: A better updating scheme for packet number as this affects maintainability in the long run

You can see my fork for a modified version of the ChatPacket and a few more classes.

Anonymous941 avatar Aug 02 '22 01:08 Anonymous941

interesting

sequoiadotdev avatar Aug 02 '22 12:08 sequoiadotdev

interesting

What do you mean?

Anonymous941 avatar Aug 04 '22 20:08 Anonymous941

I don´t know it this helps, but i found a python library that implements minecraft protocot.

https://github.com/barneygale/quarry

C2Coder avatar Dec 21 '22 19:12 C2Coder