react-native-actions-sheet icon indicating copy to clipboard operation
react-native-actions-sheet copied to clipboard

Published 20 hours ago • verified publisher icon ammarahm-ed

SheetManager.hideAll not working on 0.8.21

Open FredThiesen opened this issue 1 year ago • 4 comments

When I updated from version 0.8.10 to 0.8.21, SheetManager.hideAll() stopped working. Calling the function doesn't close the open sheets. Also tested in the 0.9.0-alpha.21, error persists.

Platform: Android React Native: 0.70.9

FredThiesen avatar Aug 10 '23 16:08 FredThiesen

Same issue here

thirdzone avatar Oct 23 '23 20:10 thirdzone

Bumping this. Still an issue 😟

lakardion avatar Feb 21 '24 19:02 lakardion

I'm experiencing this on Android/iOS.

"react-native-actions-sheet": "0.9.3",
"react-native": "0.73.7",
"react-native-gesture-handler": "2.16.1",
"react-native-reanimated": "3.8.1"

angusryer avatar May 09 '24 21:05 angusryer

When comparing the code of SheetManager.hide() and SheetManager.hideAll(), SheetManager.hideAll() is missing the isRegisteredWithSheetProvider logic. When using registerSheet(), prepending 'wrap_' to the id made SheetManager.hideAll() work in my case (v0.8.29) - I was desperate.

konstantindt avatar Aug 11 '24 18:08 konstantindt