virtme
virtme copied to clipboard
Don't try to use removed `-watchdog` arg
See https://www.qemu.org/docs/master/about/removed-features.html
Implementation notes:
-
I wrote out this numeric parsing logic for the version check to avoid a big regex. Not sure if it's worth it, LMK if you prefer and I'll just switch it back to the existing system.
-
Adding
has_watchdog_arg
everywhere looks a bit annoying, maybe better to just pass theQemu
in or something and then let architectures check whatever flags they like? -
Possibly we could just skip all this and use
-device
unconditionally, I have no idea when in QEMU's version history that became valid. In that case we can just merge #81 and delete this.
There is also https://github.com/amluto/virtme/pull/81.
Oh -_-
Well, I'll leave this open in case the simple s/-watchdog/-device
is not good enough (see my 3rd point in the summary)
@amluto has been unreachable for quite some time... do any of you know if he is still around? There a couple of fixes waiting to be picked in the PR lists already.
I just learned about https://github.com/arighi/virtme-ng, haven't tried it but maybe a viable alternative.
I just learned about https://github.com/arighi/virtme-ng, haven't tried it but maybe a viable alternative.
It works quite well, actually. You should try it :)