virtme icon indicating copy to clipboard operation
virtme copied to clipboard

Don't try to use removed `-watchdog` arg

Open bjackman opened this issue 1 year ago • 5 comments

See https://www.qemu.org/docs/master/about/removed-features.html

Implementation notes:

  • I wrote out this numeric parsing logic for the version check to avoid a big regex. Not sure if it's worth it, LMK if you prefer and I'll just switch it back to the existing system.

  • Adding has_watchdog_arg everywhere looks a bit annoying, maybe better to just pass the Qemu in or something and then let architectures check whatever flags they like?

  • Possibly we could just skip all this and use -device unconditionally, I have no idea when in QEMU's version history that became valid. In that case we can just merge #81 and delete this.

bjackman avatar Mar 08 '23 16:03 bjackman

There is also https://github.com/amluto/virtme/pull/81.

jadahl avatar Mar 08 '23 16:03 jadahl

Oh -_-

Well, I'll leave this open in case the simple s/-watchdog/-device is not good enough (see my 3rd point in the summary)

bjackman avatar Mar 08 '23 17:03 bjackman

@amluto has been unreachable for quite some time... do any of you know if he is still around? There a couple of fixes waiting to be picked in the PR lists already.

marcosps avatar Mar 08 '23 18:03 marcosps

I just learned about https://github.com/arighi/virtme-ng, haven't tried it but maybe a viable alternative.

bjackman avatar Nov 14 '23 12:11 bjackman

I just learned about https://github.com/arighi/virtme-ng, haven't tried it but maybe a viable alternative.

It works quite well, actually. You should try it :)

marcosps avatar Nov 15 '23 13:11 marcosps