ShowcaseView icon indicating copy to clipboard operation
ShowcaseView copied to clipboard

Added second button

Open kevindekemele opened this issue 8 years ago • 3 comments

Added second button + a demo in the sample app.

Second button can be added with Builder. Has similar methods as the 'Endbutton' methods.

kevindekemele avatar Apr 05 '16 18:04 kevindekemele

Like the idea but there are a few things I'd like to see changed :) just trying to make the code as great together as we can!

  • Removing the methods which add listeners together, as I don't think they are useful enough (I like the API to be as small as possible)
  • Not having a second button by default but if someone wants one they have to add it themselves using addSecondButton() on the builder

If you'd like me to, I could create a PR with what I'm thinking?

amlcurran avatar Apr 06 '16 18:04 amlcurran

Then we can compare the two

amlcurran avatar Apr 06 '16 18:04 amlcurran

Sure! I agree with your remarks. I dont really know what you mean with inconsistent format ( Im not at all a professional software designer).

You can perform your pull request with your thoughts.

kevindekemele avatar Apr 06 '16 19:04 kevindekemele