nimCSO icon indicating copy to clipboard operation
nimCSO copied to clipboard

JOSS Review Comments - Reviewer 1

Open amkrajewski opened this issue 9 months ago • 3 comments

Below are initial (itemized) JOSS review comments from @Henrium. I will progressively work on addressing them one-by-one here.

  1. I have tested in both GitHub Codespaces and Linux, the package is easy to install and works as claimed.

  2. Summary: I suggest the following to make it more accessible to "diverse, non-specialist audience": (1) introduce the background first, then what nimCSO is and what it does; (2) elaborate on the purpose and challenges.

  3. State of field: What are some other approaches to compositional space optimization; are there relevant software? References should be added if applicable. It's not necessary to compare with them, but good to make the paper informative.

  4. In quickstart.ipynb: the routine mostCommon is clear at first, but got confusing when it comes to "removing elements". What's the optimization objective of removing elements?

  5. The "Algorithm-Based Search" method relies on an assumption, "elements present in already expanded ...", is it supported by any rationale, experiments, prior studies, etc.?

  6. I didn't find "community guidelines", though it doesn't seem necessary here. Consider adding one?

amkrajewski avatar May 10 '24 15:05 amkrajewski