Andrew Kirwin

Results 137 comments of Andrew Kirwin

Initial experimentation seems like it would have the following problem. Given this example: ```hbs Foo ``` If you provided some attributes to the input, they would not spread nicely. This...

Also please can we get v5 support? ``` "peerDependencies": { "ember-source": "^3.28.0 || ^4.0.0" }, ```

Thanks. I intend to update the addon to use Intersection Observer. Hopefully that will fix it

I also like requiring the use of `assert.expect`, since junior developers may not know to reach for `assert.step` and often end up writing tests that [pass by accident](https://ember-twiddle.com/b2f000520fa51c3a35bbc1162b9c43e9?openFiles=tests.integration.components.my-component-test%5C.js%2Ctemplates.components.my-component%5C.hbs).

Seems to only be the case when `fingerprintAssetMap: false`

What's the situation with this? I've had `'hbs/check-hbs-template-literals': 'off'` for a while now and eager to get it back on

Also seeing this: ``` Uncaught Error: Assertion Failed: The `element` helper polyfill encountered an unexpected error. Please report the issue at http://github.com/tildeio/ember-element-helper with the usage and conditions that caused this...

It seems like perhaps the replacement technique is to use webpack's `webpackPreload: true`. But that feature is actively [not a thing](https://github.com/embroider-build/ember-auto-import/issues/182#issuecomment-459491845) in an embroider app 🤔

Approach number 2. seems to be working... ish Some things I learned along the way: * > It outputs: `` does not exist on disk. If this is intentional, use...