Andrew James

icon indicating an email [email protected]

icon company @quansight

Results 34 comments of Andrew James

[BE][Typing][Dynamo] Type torch/_dynamo/variables/dicts.py

cc @rec might be interesting to see how this diff looks wrt the type completeness delta summary.

Add Experimental limited sparse embedding bag

A note for reviewers: the failure in xla_op1 shard appears to be unrelated, the tests for the new feature are in xla_op3

How to prevent landing PRs on sparse tensors that should be rejected?

+1 to adding CODEOWNER entries. > 1. Add a comment saying "Do not implement checks that can be enabled by check_sparse_tensor_invariants" to sparse tensor constructor implementations where one should want...

"RuntimeError: !at::functionalization::impl::isFunctionalTensor(t)" when running a DTensor test with functionalization on

I can take a look at this it is the same issue I was dealing with.