Amiti Uttarwar

Results 17 comments of Amiti Uttarwar

I don't think this is a significant improvement, but the slight improvement seems fine since it's small, easy to check that there's no delta in behavior, and doesn't conflict with...

approach ACK > (the address manager interface does not support removing addresses at the moment and adding this seems to be a bigger effort) since right now the only way...

to minimize the complexity that we need to maintain over time, we try to reduce the amount of client-side niftiness that we offer. it seems to me that the string...

light code review ACK 7c34c35b47. tested that the RPC and cli endpoints make sense & handle errors reasonably. these changes will require release notes, which can be done here or...

I think this PR should be in draft right now since it builds on top of #27511 & has some outdated changes / the two commits are represented as a...

+1 to the questions asked by @naumenkogs. I agree with the statement in the OP that this change would "avoid a lot of unnecessary addrman `Select` calls (especially when...", but...