blocktube icon indicating copy to clipboard operation
blocktube copied to clipboard

Comment blocking appears to be broken

Open lazarusinashes opened this issue 4 months ago • 34 comments

Comment blocking appears to no longer work. No block channel option appears in the context menu and comments that match the filter still appear despite reinstalling the extension.

lazarusinashes avatar Apr 04 '24 22:04 lazarusinashes

I am having this issue also. None of my comment content filters are working as of today.

artcytracy avatar Apr 06 '24 07:04 artcytracy

same i am now pestered by hundreds of wrong opinions in my comment sections

FlashlightET avatar Apr 07 '24 03:04 FlashlightET

same i am now pestered by hundreds of wrong opinions in my comment sections

What wrong opinions?

sawtoothpuma avatar Apr 08 '24 03:04 sawtoothpuma

What wrong opinions?

Yours, specifically

TimeEditor avatar Apr 10 '24 06:04 TimeEditor

same

abudulamh avatar Apr 10 '24 10:04 abudulamh

What wrong opinions?

Yours, specifically

What do you mean by that?

sawtoothpuma avatar Apr 10 '24 11:04 sawtoothpuma

What wrong opinions?

Yours, specifically

What do you mean by that?

@sawtoothpuma Please keep this thread related to the technical issue. This is not the YouTube comments section.

artcytracy avatar Apr 11 '24 15:04 artcytracy

Same

Warning-Forever avatar Apr 11 '24 17:04 Warning-Forever

it's not just the context menu. The entire comment blocking function is broken. They are not blocked even if you add the channel id manually.

idomori avatar Apr 12 '24 16:04 idomori

Yeah, same for me. It doesn't work anymore. The block comment option is unavailable. I can only use the classical report button from youtube that doesn't prevent you from seeing the comment anyway. Does anybody have a clue about this issue?

kuroman96 avatar Apr 12 '24 19:04 kuroman96

Yep, just spent the last five or ten minutes trying to figure out what I was doing wrong with my regex filters, before it finally occurred to me that perhaps comment blocking isn't working at all.

De-Troll YouTube also broke recently, and when I contacted the dev he said it was because "YouTube changed some of their tags", so maybe this is caused by the same issue?

@sawtoothpuma

What wrong opinions?

Yours, specifically

What do you mean by that?

I think they were being facetious.

SavannahJohnston avatar Apr 14 '24 17:04 SavannahJohnston

@SavannahJohnston Yes Youtube has been pushing a lot of updates in recent months. Every few weeks now it seems that it conflicts with one of my multiple adblocker extensions or BlockTube. It's a lot of work to stay one step ahead of them. I am a developer but I mostly do backend work in Python. I may start looking at the code however and see if I can't start contributing to the maintenance of some of these brilliant extensions that I rely on so heavily!

artcytracy avatar Apr 14 '24 19:04 artcytracy

same i am now pestered by hundreds of wrong opinions in my comment sections

I personally use it to block annoying overused jokes ("I took that personally" and "plot twist:" are both in it) and I never knew how much I would miss comment blocking

lazarusinashes avatar Apr 17 '24 16:04 lazarusinashes

It would be great if there was a short (or longer) tutorial here showing us how to fix errors within blocktube that had been introduced by youtube updates. I know a little bit of javascript but couldn't figure out how to debug this.

So if someone here has clues, I'd be happy to look into it – the comment section is just unbearable for me without blocktube.

@artcytracy, since you already mentioned you might look into it maybe you got clues?

GithubAnon0000 avatar Apr 17 '24 17:04 GithubAnon0000

It actually just now suddenly works again... What is going on? I didn't change anything.

GithubAnon0000 avatar Apr 17 '24 22:04 GithubAnon0000

It actually just now suddenly works again... What is going on? I didn't change anything.

What specifically is working again for you?

The comment blocking and filtering is still broken for me. This includes the menu options for blocking comments and users within the comments section which are typically in the same menu as "Report". image As an atheist I find religious content offensive. So this is the sort of content I have in my filters which are also not working.

The video and channel blocking are still working fine on my end.

I was about to pull down the code and have a look at it this evening.

artcytracy avatar Apr 18 '24 00:04 artcytracy

What specifically is working again for you?

Well, all comment content rules worked again. I was offline for a few hours now, opened youtube again and the blocking doesn't work anymore... In #394 I mentioned that it is random for me. But now most of the time it doesn't work at all, so I thought it was permanent.

I did try to see if I could reset the password (see #398) and moved blocktubes files out of the profile directory. And I set a password in blocktube. But I fail to see how this could've made blocktube working again. I'll experiment though.

EDIT: I couldn't reproduce it with what I did before. To me it really seems to be working (or not working) randomly. I also never use context menu blocking. I open blocktube directly and add the rule there. If you've got any idea on how to possibly debug this, feel free to post it here.

GithubAnon0000 avatar Apr 18 '24 04:04 GithubAnon0000

I cloned the repo and tried to get setup on my desktop this evening but getting the project configured with Ubuntu to do a local build is proving quite complicated. I will try it on my work macbook tomorrow. I also know a little JS and did have a quick look at the code ~~but nothing obvious yet~~.

I'm seeing ytd-comment-view-model in YouTube page inspection but not in BlockTube code.

@SavannahJohnston I looked at the recent commits for De-Troll-YouTube and he added the aforementioned syntax so thanks for that tip.

It's possible we may need to append usage of ytd-comment-renderer to include ytd-comment-view-model as jscher2000 did here. Just a bit of a wild guess though.

artcytracy avatar Apr 18 '24 05:04 artcytracy

I'm not a developer at all and I know nothing about coding. I came here to look if someone had some clues to fix the issue. Maybe someone who knows amitbl could get in contact with them and ask about this. Unfortunately, I can't do anything to help at my level. I can only realize how very useful blocktube was and how much I miss the comment blocking option.

kuroman96 avatar Apr 18 '24 19:04 kuroman96

I'm seeing ytd-comment-view-model in YouTube page inspection but not in BlockTube code.

@SavannahJohnston I looked at the recent commits for De-Troll-YouTube and he added the aforementioned syntax so thanks for that tip.

It's possible we may need to append usage of ytd-comment-renderer to include ytd-comment-view-model as jscher2000 did here. Just a bit of a wild guess though.

I tried to get it to work but I couldn't. I wish JS was more like C Programming... One thing is certain though. ytd-comment-renderer is referenced in inject.js (line 1577) so I guess that's the file we would need to change. Adding else if ('YTD-COMMENT-RENDERER' === parentDom.tagName || 'YTD-COMMENT-VIEW-MODEL' === parentDom.tagName) { as an example doesn't work though.

For everyone that might want to try it: it's fairly easy to use debian stable, download the dependencies and then try out the changes (since @artcytracy said that it doesn't work well with ubuntu).

I'm very interessted to see the commit and check out what exactly had to be changed to make it work again. If there are additional tipps here, I might try my luck again but I'll leave it be for now.

GithubAnon0000 avatar Apr 18 '24 23:04 GithubAnon0000

For everyone that might want to try it: it's fairly easy to use debian stable, download the dependencies and then try out the changes (since @artcytracy said that it doesn't work well with ubuntu).

To clarify, I was trying to setup Windows Subsystem for Linux but that requires me to enable visualization for Hyper V which involves going into my BIOS settings and even then might fail because of my non pro version of Windows. I didn't want to go down that rabbit hole yet.

I just did a build and unpacked the extension on my macbook and it was a lot easier than I thought it would be. I will play around with it this evening but I'm not very hopeful. I'm not a very bright crayon.

artcytracy avatar Apr 19 '24 00:04 artcytracy

Just as a side note: I wonder if youtube is trying out new interfaces that look identical but aren't on a code basis. Because currently all comment content filters work perfectly fine.

Either that, or they suddenly started to work after I left my browser on for a few hours (but why would that be the case?).

If this was C I'd just run a debugger and know why it works only sometimes and not always. Of course there is the dev tools page and the console, but it's not useful to solve this problem (to me, at least). If we figure out the root cause of this, then we'll be able to solve it much more efficiently – including in the future, if new problems arise.

GithubAnon0000 avatar Apr 19 '24 06:04 GithubAnon0000

Just as a side note: I wonder if youtube is trying out new interfaces that look identical but aren't on a code basis. Because currently all comment content filters work perfectly fine.

If they were testing new interfaces they would likely not make it live until they've thoroughly tested it in a dev environment.

However, a few weeks ago something changed where my entire comments section was swapped with the video thumbnails that are usually in the right column. It remained that way until a week or two later and suddenly reverted back to the typical display.

I've had a look at the console but I don't see any relevant errors. I also inspected the page elements. I learned I can manipulate the comment text which is kind of cool. But this isn't helping me understand the logic in inject.js. I think the filter logic is working but is likely not being applied to the correct element anymore.

I've also recently cleared caches and cookies in YouTube which resolved another issue I was having with it flagging content as unavailable in YouTube's restricted mode, which I do not even have enabled. That doesn't have any effect on content blocking though.

What OS and browser are you using?

artcytracy avatar Apr 20 '24 06:04 artcytracy

However, a few weeks ago something changed where my entire comments section was swapped with the video thumbnails that are usually in the right column. It remained that way until a week or two later and suddenly reverted back to the typical display.

I still have the normal view. However, every once in a while I also get this layout. But then I just close my browser and open youtube again and the interface is normal again. My browser is configured to always delete browsing data, cookies etc. when I close it – maybe that's relevant here.

I've had a look at the console but I don't see any relevant errors. I also inspected the page elements. I learned I can manipulate the comment text which is kind of cool. But this isn't helping me understand the logic in inject.js. I think the filter logic is working but is likely not being applied to the correct element anymore.

Indeed. However, I did compare the html layouts of youtube for a) blocktubes comment blocking doesn't work and b) blocktubes comment blocking does work. I couldn't see any noticeable differences and YTD-COMMENT-VIEW-MODEL was present in both too.

What OS and browser are you using?

I am using Debian GNU/Linux (oldstable) with LibreWolf 124.0.1-1 (a firefox fork).

PS: Thanks for looking into it @artcytracy . It's nice to have a real developer look into it too, even though it's not your field of expertise.

GithubAnon0000 avatar Apr 20 '24 13:04 GithubAnon0000

Comment block never occasionally worked for me. It's just broken for good

idomori avatar Apr 29 '24 08:04 idomori

Yeah it doesn't work for me either. I miss being able to read comments sections without them being clogged with unfunny memes and teenagers who say "bro" every other word.

Diana-Mundanna avatar May 17 '24 14:05 Diana-Mundanna