French translation

[SpicyWasab]

Hi !

Here's a new pull request for the French translation.

I'm unsure about a few things :

• Should I translate "Mousam" ? 😅
• A few other little things (mostly about the length of some strings, or their context). I'll made a review when it gets implemented in the app !

Have a nice day !

[amit9838]

No, nouns(mousam) are not translated 🙂 , Huh, Some sentences are longer (more than 2x) , i'm not sure how it is going to fit into the UI, can you share some Screenshots.

[SpicyWasab]

Alright ! I just wasn't sure about the origin of "Mousam", if it meant "weather" in some unknown language or anything. (where does the name come from btw ?)

When you say "share some screenshots", you mean actually building the app from the code source to take a look at the translated UI ?

[amit9838]

Mousam means weather in Hindi, About screenshots, if you have set dev environment , you can share the screenshots, otherwise no issue 🙂

[SpicyWasab]

Ohh, alright !

I've just cloned my repo and opened it with Gnome Builder. I can run the app, however I'm not sure how to get the translated UI from my .po file, if I should link the file somewhere or anything.

[LukaszH77]

@SpicyWasab In Builder you have to Build the app first, then you can Export it to a flatpak package and install it. Let me know if you need more detailed instructions.

[SpicyWasab]

Hi again, I wasn't much available the past few days. (today's my 18th birthday btw :partying_face:)

Thanks for the instructions. I also figured I forgot to link my fr_FR.po file in the LINGUAS file ^^'

Some strings were clearly to long, so I managed to shorten them. Here's a screenshot.

However, as you can see, some parts of the UI are still in english. I tried to see if I somehow tempered with their msgid, but they're not different from the ones listed in the original mousam.pot file. Furthermore, I also tried to look for the _("string id") gettext calls, and it's the same msgids as well.

~~Do you have any idea why the top and right cards aren't translated ?~~

edit : I figured it out. The fact that the translation was working on a UI card to card basis hinted me that some files had something different from the others : the python files that imports the _ from gettext doesn't translate at all. Removing the import makes it work as intended. I don't know much about gettext, and I only have the basics in GNOME and Python development, but I guess you once needed to import it on each files, and at some point you made the gettext function a global function or something. Maybe the files that still imports the function overwrites the good one for the current one, and that's why the translation doesn't work properly on those parts of the UI.

[amit9838]

On this grand day, as the clock ticks to mark your 18th orbit around the sun, let the universe applaud your arrival into adulthood! 🎉 Embrace the journey ahead with zest, courage, and a sprinkle of stardust, for you are destined for greatness! 🌟 Happy Birthday @SpicyWasab !

[SpicyWasab]

Thanks ! That's so poetic I like it haha

Here's the translated ui so far. The only untranslated things are :

1. "Day High" and "Day Max", aren't translated because they're not called with the gettext function in frontendHourlyDetails.py (actually, "Day Max" isn't defined in mousam.pot) ;
2. "Light Rain Showers", there's no entry for it in mousam.pot.

Even though python isn't my favourite language, I guess I could easily fix these alongside this pull request if you want.

[SpicyWasab]

I'm gonna sleep (it's actually 3:33), so I may not answer before a few hours :')

[amit9838]

Talking about the pr 😂, .pot file is updated with the valuable contribution of @LukaszH77 , he has added strings with context, maybe now you can translate it better. Take your time, celebrate your Birthday 🎂 - Good Luck

[SpicyWasab]

Hi, thanks ! I read your message a while ago but I was kind of busy after that.

I'm gonna work on it right now, hopefully I'll make another PR / update this one in a few hours c:

Edit : I guess it was already translated 2 months ago haha

[amit9838]

@SpicyWasab hope you are doing good, actually i'm planning to release the app very soon so it would be nice if you can translate the remaining strings. Thanks

[SpicyWasab]

@SpicyWasab hope you are doing good, actually i'm planning to release the app very soon so it would be nice if you can translate the remaining strings. Thanks

Yeah thanks, hope you're doing good as well !

Oh, I didn't noticed some strings were untranslated. I'm going to check this out, probably tomorrow morning !

[SpicyWasab]

~~Now that I'm digging more into the file, It honestly seems obvious that the previous guy used google translate to translate ^^' Mostly because some strings seems to be litteral translation, so I was a bit suspicious. But, I mean, paying attention to the beginning of the file...~~

The comments and the legals got weirdly translated as well. They didn't even put their name in the "Last-Translator: FULL NAME" line, they put the french translated equivalent of "FULL NAME" instead :')

~~The same goes for the german translation, tough my german skills are pretty terrible so I can't tell if the translation is good or not.~~

~~Honestly, I would say it's not a big issue, an unperfect translation may be better than no translation at all, and even though I initially found some strings pretty weird, none of them felt absolutely wrong. I'll definitely retranslate some of them tomorrow though, and put my nickname in the "Last translator" thing.~~

But I'm wondering what should be put in the translator's name for the german version, I guess if there's no change made our german friends will litterally see "Translation by: VOLLSTÄNDIGER NAME EMAIL@ADRESSE". Pretty funny ngl, but I guess having something else would be better lmao. Maybe ask him if he wants his name for the translation ?

EDIT : apparently it was their first ever pull request, the account seems new as well. French also seems to be their primary language, so I think I was totally wrong. Maybe it was their first time translating and they aren't used to this, so they translated the whole thing.

SECOND EDIT : now that I'm really reviewing the translation, their translation is good, sometimes better than mine ! I'm still changing some little things but nothing really wrong. Still weird to have translated the comments and all but the actual translation is good, I was clearly wrong about my google translate theory so I'm really sorry about that ^^' There's still no name for the german translator though :thinking:

[amit9838]

Yes, He hasn't translated before this. Sure i'll ask him to add his name and email in the .po file for German. Thanks for translating remaining strings. 🙂 . Merging the pr. This pr was stuck for too long 😆.

[SpicyWasab]

Fine, thanks for taking the time to ask him for his name and email ! Granting some recognition to translators is important imo.

Yeah, it was open for too long, but actually hum, I didn't pushed the remaining changes to the master branch since I didn't finish reviewing the remaining strings haha ^^'

Is it possible to reopen the pull request or should I open another one to replace the file ?

Also, I got some warnings about the same msg id being present multiple times. (particularly those for the wind and humidity "light, moderate and high" values if I remember right). Is this normal ?

[amit9838]

IMO msg id should be unique, if two msg_id are same then it must have context which makes it unique. Would be nice if you open new pr for this.

[SpicyWasab]

Alright, I'll open another PR in a few hours when the translation looks good to me ! Yeah they have the same msg_id but a different context. I guess It's fine then !