Same-level elements with common prefix

[mattbornski]

Summary

Allow elements at the same level with a common prefix to be unflattened

Bug Fixes/New Features

• Fix a bug where a piece of logic designed to suppress conflicts when basic values and flattened structures claimed the same key space; the logic inadvertently suppressed scenarios where multiple basic values existed with keys where one key was a prefix of the other.

How to Verify

A new test has been added for this scenario

Side Effects

Possible if you are depending on these keys being silently dropped?

Resolves

• A bug discovered and reported here

Tests

All tests, including the new one, pass

Code Reviewer(s)

@

[pep8speaks]

Hello @mattbornski! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-10-08 21:50:10 UTC

[amirziai]

thanks for the pr @mattbornski, do you mind checking why the travis build is failing?

[mattbornski]

The same reason every other one of your PR builds is failing mate.

On Sat, Oct 5, 2019 at 4:24 PM Amir Ziai [email protected] wrote:

thanks for the pr @mattbornski https://github.com/mattbornski, do you mind checking why the travis build is failing?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amirziai/flatten/pull/50?email_source=notifications&email_token=AAAYV7KO2B74NH2IIVIK73LQNEO4DA5CNFSM4H5JGGC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAN56FA#issuecomment-538697492, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAYV7N7PAGG5RCHB7DBB7LQNEO4DANCNFSM4H5JGGCQ .