Amir Hossein Hashemi

Results 27 comments of Amir Hossein Hashemi

Looks like it's been fixed in the latest version.

I'm experiencing the same bug. `isSameDay` returns a wrong result when I compare a Gregorian date with a Persian date: ```ts const persian = new CalendarDate(new PersianCalendar(), 1401, 12, 8);...

> I wonder if there's an eslint rule to prohibit it. Looks like there isn't (and probably won't be) an official rule for that. https://github.com/eslint/eslint/issues/10264 But there are plugins that...

@dai-shi Yeah I think it works. I reverted the old commit and just changed the rollup config. Before: ```sh $ yarn run build $ grep -o 'catch{' ./dist/**/*.js ./dist/system/vanilla/utils.production.js:catch{ ./dist/system/vanilla/utils.production.js:catch{...

> btw you want to grep `catch {`. Isn't the build output minified? `catch {` -> `catch{`

I tried `catch {` and the result is the same: Before: ```sh $ grep -o 'catch {' ./dist/**/*.js ./dist/system/vanilla/utils.development.js:catch { ./dist/system/vanilla/utils.development.js:catch { ``` After: ```sh $ grep -o 'catch {'...

Wired. I tried it again and it seems to be working. I even tried a grep that covers more scenarios: `grep -o "catch\s*{" ./dist/**/*.{js,ts,mjs,mts,cjs,cts}` Did you run `yarn run build`...