DuckX icon indicating copy to clipboard operation
DuckX copied to clipboard

Added function to add new line.

Open nxiss7 opened this issue 5 years ago • 5 comments

I think adding new lines is a common task, it's a must-have feature for me.

nxiss7 avatar Mar 08 '20 19:03 nxiss7

Thank You for the PR!

I think it would be better to define new_line as a constant. refer to python-docx library, we can define an enum/class (e.g BREAK) that has a value called LINE. So user can add a new line break like this:

p.add_run(duckx::BREAK::LINE);

Feel free to send PRs :)

amiremohamadi avatar Mar 09 '20 16:03 amiremohamadi

Ok, will take look and update code. :D

nxiss7 avatar Mar 09 '20 20:03 nxiss7

After a few busy weeks I could finally refactor the code. I also added support for columns and tab character too.

nxiss7 avatar Mar 27 '20 19:03 nxiss7

This PR seems ready to be merged in. Any tests to add or verify for this?

SimantoR avatar Jan 01 '23 07:01 SimantoR

This PR seems ready to be merged in. Any tests to add or verify for this?

Hi @SimantoR, it seems ready but after completing #81 this will be merged.

amiremohamadi avatar Jan 01 '23 09:01 amiremohamadi