amiquip icon indicating copy to clipboard operation
amiquip copied to clipboard

Add an example for reading message headers

Open kaxap opened this issue 4 years ago • 6 comments

Addressing #23

kaxap avatar Jun 27 '20 00:06 kaxap

@jgallagher is this fine, or is it better to create an example file in examples folder?

kaxap avatar Jun 27 '20 20:06 kaxap

bump

kaxap avatar Jul 07 '20 13:07 kaxap

any feedback on this?

kaxap avatar Aug 01 '20 20:08 kaxap

@kaxap Sorry I left this hanging for so long! This doesn't work as currently written because the delivery module is private, so the example you added doesn't show up in the generated pages from rustdoc.

I think it would be great to add something that demonstrates this to the examples, though. All the current examples have a partner example that can be run at the same time to see it in action. What would you think about this plus a corresponding example that sends messages with a custom header set?

jgallagher avatar Nov 13 '20 01:11 jgallagher

hey, thanks for the reply! Unfortunately, I am not programming in rust for the last couple of months. I'll give this MR another try maybe in 3-4 weeks time if that's okay.

kaxap avatar Dec 26 '20 00:12 kaxap

Sure, no problem! 👍

I left this hanging for a long time, take as much time as you want.

jgallagher avatar Dec 26 '20 01:12 jgallagher