re-carousel icon indicating copy to clipboard operation
re-carousel copied to clipboard

Adding functionality to set frame index directly

Open liuloppan opened this issue 5 years ago • 3 comments

  • Adding functionality to set the intital "current frame index" by passing it as a prop into Carousel.
  • Adding the function setFrame to Carousel and passing it as a Widget prop ('setFrameHandler') which can be used by Indicator dots to transition multiple frames at once.

liuloppan avatar Dec 01 '19 20:12 liuloppan

Solves issues: #125 #100

liuloppan avatar Dec 02 '19 21:12 liuloppan

Thanks @liuloppan! will look into it soon :D

amio avatar Dec 03 '19 03:12 amio

@liuloppan Great! Just a few changes:

  • since loop cannot work with currentFrameIndex, we should log a warning in case of that,
  • let's keep the default demo as original, add some description of currentFrameIndex in README.md
  • loop works with my intended use of currentFrameIndex, I renamed it to onStartFrameIndex and added description in README.md
  • I changed back to the original demo index.js

liuloppan avatar Apr 27 '20 21:04 liuloppan