emoji.json icon indicating copy to clipboard operation
emoji.json copied to clipboard

Add status + Add version + Update data example + Add type and rule validation

Open angelofan opened this issue 1 year ago • 3 comments

For #13

Added status properties to support various custom filtering.

For #14

Added version.

Other

  • Updated content of data examples in readme file.
  • Updated emoji.json

Edit:

For https://github.com/amio/emoji.json/pull/27#issuecomment-1877101748

Add type and rule validation before writing the full data to the emoji.json.

angelofan avatar Dec 30 '23 07:12 angelofan

@angelofan Great work!

I guess we would need a test to verify that the generated json fulfills our type definition, just in case the regex fails someday.

amio avatar Jan 04 '24 13:01 amio

@angelofan Great work!

I guess we would need a test to verify that the generated json fulfills our type definition, just in case the regex fails someday.

Good idea. I will try adding type validation before writing the final array to the file.

angelofan avatar Jan 04 '24 14:01 angelofan

@amio I added type and rule validation.

angelofan avatar Jan 04 '24 17:01 angelofan