project_options icon indicating copy to clipboard operation
project_options copied to clipboard

The project_options should only FetchContents of other repos with stable versions tags

Open ClausKlein opened this issue 3 years ago • 1 comments

Some of the other CMake git repos used by this project have no stable git tag.

  • Would it be possible to change this?
  • Would it also possible to document this dependencies too?
  • Is it possible to always use FetchContent_MakeAvailable()?
  • see https://github.com/ClausKlein/project_options/pull/5#pullrequestreview-1114348013

i.e.

  # in PackageProject.cmake
  # download ForwardArguments
  FetchContent_Declare(
    _fargs
    URL https://github.com/polysquare/cmake-forward arguments/archive/8c50d1f956172edb34e95efa52a2d5cb1f686ed2.zip)

# in VCEnvironment.cmake
# Using Windows MSVC toolchain
FetchContent_Declare(
        _msvc_toolchain URL "https://github.com/aminya/Toolchain/archive/95891a1e28a406ffb22e572f3ef24a7a8ad27ec0.zip")

ClausKlein avatar Sep 20 '22 15:09 ClausKlein

@lefticus @aminya please note this brand new CMake v3.24 option I want to use:

cmake -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=$PWD/mycomp_provider.cmake -S . -B build -G Ninja -Wno-dev

ClausKlein avatar Sep 20 '22 19:09 ClausKlein

see too https://discourse.cmake.org/t/fetchcontent-vs-vcpkg-conan/6578

ClausKlein avatar Oct 07 '22 08:10 ClausKlein

Since v0.26.1 all the fetch contents are based on a stable tag

aminya avatar Oct 28 '22 20:10 aminya