Amin Ya

Results 1114 comments of Amin Ya

> If a terminal is not already open nothing happens. We should fall back to the original method in these cases It seems it is fixed. But not sure why...

> > Possibly reintroducing the `fs.coffee` wrapper so that `try/catch` blocks can be consolidated into that file. > > I'd recommend doing this. I think I was a bit too...

> > Personally, I prefer that we add the functions that `fs-plus` misses (from `fs-extra` and `wrench`). > > I'm not too sure what you mean here; are you saying...

I am not against using better libraries, but there should be a benefit in doing so. For example, I am [replacing `etch` with `solid`](https://github.com/ryansolid/solid/issues/206). But to make the transition seamless,...

If you want to do this only for `apm`, you should first merge all the open pull requests. This pull request is changing all the files of `apm` and so...

Related to this. https://github.com/atom/fs-plus/pull/50

Is there any update or workaround for this?

On my system, it takes 160ms. Doing some profiling during loading, most of the time is spent in these lines of code: ![image](https://user-images.githubusercontent.com/16418197/74303832-be95c500-4d20-11ea-9e6a-8440c528a9c2.png) The lowest level is here: https://github.com/file-icons/atom/blob/cfb2a1c3965963b3f0700592bab6207e7c24ebc4/lib/service/icon-delegate.js#L245 Can't...

> > > @aminya During loading, the package has to run almost [2,000 regular expressions](https://github.com/file-icons/atom/blob/master/lib/icons/.icondb.js) against every filename that's visible in the workspace. It's already memoising each result to reduce...

> > > Yes, it's pure JavaScript. Doing a quick check with a simple algorithm, it takes **15ms** for my Julia code to check 100 words against a 2000 regex...