Amin Ya

Results 1114 comments of Amin Ya

@suda @ericcornelissen any solution for the tool-bar width changing issue? I cannot make the dropdown be a float thing separate from the tool-bar width.

I think we need to add a floating dropdown and position it under the actual button and not appendChild it to the tool-bar.

I found this video. It is maybe related. https://www.youtube.com/watch?v=IF6k0uZuypA&t=619s There are other ones too: https://www.youtube.com/results?search_query=dropdown+menu

> I'm personally not a fan of this, as it actually changes the tool-tip as seen here: > > Before After > ![before](https://user-images.githubusercontent.com/3742559/84393630-7fab4980-ac04-11ea-9d93-77307701eb3b.jpg) ![after](https://user-images.githubusercontent.com/3742559/84393636-80dc7680-ac04-11ea-85aa-82728f7e190a.jpg) > I would be fine with...

> > We can certainly make a PR to Atom, and see why this key-binding adding takes time. > > I prefer that 100% over just removing this feature from...

Let's keep it open for the future reference. If I close it, it might get lost 😄

Further investigation shows that the time is spent here, to add `keyBindingCommand`, which is because we set `keyBindingCommand` even when the user gives it `null` https://github.com/atom/atom/blob/e4b9c1e0815c5c07514a0649e7ebb9b5226a2931/src/tooltip-manager.js#L126-L139 ```js const { keyBindingCommand,...

@rsms Could you shed some light on this issue? Is this possible given the current codebase?

So do you think that editing the HTML code blocks (adding colors) after getting the initial markdown would have better performance?

Thank you so much! ❤️ The only issue that I have now is that `onCodeBlock` is a synchronous function, while my highlighting function is asynchronous. I might be able to...