ember-data-url-templates icon indicating copy to clipboard operation
ember-data-url-templates copied to clipboard

Fastboot Support

Open aaronfischer opened this issue 8 years ago • 3 comments

Hello! Curious if it is anywhere in the roadmap to support FastBoot? (We love and have used ember-data-url-templates on just about every project.)

Working on converting my existing ember app to use FastBoot for the first time and I'm getting a There was an error running your app in fastboot. More info about the error: ReferenceError: UriTemplate is not defined.

References this block:

compileTemplate: function compileTemplate(template) {
  return new UriTemplate(template);
},

aaronfischer avatar Feb 14 '17 16:02 aaronfischer

Hi @Aaronfischer.

I don't have any apps using FastBoot, so I don't have much context on how to fix this or a way to test it. It looks like an issue with the way ember-data-url-templates is using bower to load UriTemplate though.

I would love for ember-data-url-templates to support FastBoot, and if you have the drive to figure out how to make it so, I would super appreciate a pull-request :)

amiel avatar Feb 14 '17 17:02 amiel

Hey @amiel!

All good, could you tell me a bit more about UriTemplate? Assuming this is an npm dependency that your addon loads/exposes globally?

aaronfischer avatar Feb 14 '17 21:02 aaronfischer

@Aaronfischer Yeah, it gets imported here: https://github.com/amiel/ember-data-url-templates/blob/master/index.js#L8, but this is probably the culprit: https://github.com/amiel/ember-data-url-templates/blob/master/addon/mixins/url-templates.js#L3.

amiel avatar Feb 14 '17 21:02 amiel