mice icon indicating copy to clipboard operation
mice copied to clipboard

Published 20 hours ago • verified publisher icon amices

IPD Heckman imputation method

Open johamunoz opened this issue 2 years ago • 9 comments

New imputation method for individual patient data (IPD) and cluster data that follow a MNAR mechanism according to the Heckman selection model.

johamunoz avatar May 04 '22 14:05 johamunoz

@johamunoz Unfortunately, the checks failed... Could you please try to solve the CMD check WARNING?

hanneoberman avatar May 05 '22 14:05 hanneoberman

Thanks a lot Hanna!! I will try

Have a lovely day!!

Johanna

On 5 May 2022, at 16:20, Hanne Oberman @.***> wrote:

@johamunoz https://github.com/johamunoz Unfortunately, the checks failed... Could you please try to solve the CMD check WARNING?

— Reply to this email directly, view it on GitHub https://github.com/amices/mice/pull/485#issuecomment-1118614537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB55T233PE4TDMRLPG4EZCDVIPKLXANCNFSM5VCGBQ3A. You are receiving this because you were mentioned.

johamunoz avatar May 05 '22 14:05 johamunoz

Hi Johanna, looks good! But would it be possible to add your function without so many dependencies? Currently, there are a hand full of packages added to the Imports part of the DESCRIPTION file. Preferably, these should be added under Suggests instead. The install.on.demand function then takes care of any missing dependencies whenever someone uses your imputation function.

hanneoberman avatar May 09 '22 13:05 hanneoberman

Hi Johanna, thanks for your contribution. Found some final glitches:

  • class(mvma) == "try-error" produces a note. Better use inherits
  • Please put package names in alphabetic order
  • Please move Matrix to suggests, and check that you've use Matrix:: everywhere

stefvanbuuren avatar May 09 '22 14:05 stefvanbuuren

Thanks to you for allowing me to contribute in your package!! I have updated the code following your suggestions.

johamunoz avatar May 10 '22 09:05 johamunoz

@johamunoz Unfortunately, one of the checks failed again. Could you please try to solve the error? Let me know if you need some help!

hanneoberman avatar Sep 06 '22 13:09 hanneoberman

Hi Hanna!! Thank you very much for checking this update!!. I'm not sure about the Ubuntu error but it looks like it could be a bug with the installation order. The only thing I found is that one of the suggested packages GJRM depends on another suggested package (mgcv). I have removed the last one from the suggested list of packages. Could you please check it again? Thank you very much for always helping me, Johanna

johamunoz avatar Sep 08 '22 10:09 johamunoz

:(

johamunoz avatar Sep 08 '22 11:09 johamunoz

Hi Hanna! Again sorry to bother you with this, but I am super lost and I dont know how to proceed.. :(

  1. Could you please approve the last change again? Also, I would like to ask you please :
  2. if you know how to extract the process list? To be exact, I know there is a problem in process 9626, probably it's the installation of a package but I don't know which one.
  3. From the list of packages to install I see only the packages with installation suggestion but not their dependencies. Do you know if this list should show both types of packages? Again thank you very much for your great help,

Kind regards, Johanna Johanna

johamunoz avatar Sep 08 '22 12:09 johamunoz

See #500

stefvanbuuren avatar Oct 31 '22 20:10 stefvanbuuren