fosswebsite icon indicating copy to clipboard operation
fosswebsite copied to clipboard

Published 20 hours ago • verified publisher icon amfoss

Changes in the home page, footer and signup successful page

Open sreyasukavasi3 opened this issue 6 years ago • 4 comments

Prevented the overlapping of icons on the home page. - 763cd15 Prevented the footer to go up when there is no content in the page. - fdb8060 Adjusted the signup successful page in registration. - bf7cfa2

sreyasukavasi3 avatar Sep 14 '18 14:09 sreyasukavasi3

Why is the PR commit message/title like this? Please make sure you name the PR rightfully according to the issue that you wish to solve. I see various other commits too after the PR was initiated. Are these relevant to the PR that you opened? If then, make sure you merge all together and open up a single commit.

Aniketh01 avatar Sep 16 '18 04:09 Aniketh01

@sreyasukavasi3 Please provide some screenshot for your changes.

chirathr avatar Sep 16 '18 05:09 chirathr

commit 8a7a2b91080ff6c09611dff89cd5b047b340c3ef

1

Changed to

issue

sreyasukavasi3 avatar Sep 16 '18 11:09 sreyasukavasi3

Prevented the footer to go up when there is no content in the page. - fdb80601 I guess this is not the correct way to do this. You just increased the margin-top this may sometimes create a lot of space in between if there is no content. Changing it would be better. @sreyasukavasi3 can you also put some screenshots regarding the signup successful page? And I am still able to reproduce this issue amfoss code share grow - mozilla firefox_005

rammanoj avatar Sep 17 '18 11:09 rammanoj