space-menace icon indicating copy to clipboard operation
space-menace copied to clipboard

Framerate independence

Open Jazarro opened this issue 4 years ago • 3 comments

At the moment, whenever there is a drop in frames the characters noticeably slow down. When running in debug mode, it is common (at least on my laptop) for framerates to occasionally drop down to 30-40 fps. This causes a very noticeable and irritating jank in the characters' movements.

It would be desirable if the movements and animations advanced as a function of time passed, rather than number of frames passed.

  • Entity velocities should be expressed in m/s, rather than m/frame
  • Translation should be updated by adding velocity times delta seconds

I'd like to give this a go, if nobody is working on this yet. Any input is welcome. :)

Jazarro avatar Nov 01 '19 22:11 Jazarro

@ABoschman Thanks for logging this issue. This is a must have feature. Though somehow I neither logged an issue for it nor worked on it (kept putting it off actually). Glad that you brought it up and want to work on it. Much appreciated. Assigned it to you.

On a different note, I noticed that your name doesn't show in the contributor's list. It seems like you have set a different email id for this repository than the one you have set for your GitHub account. You might want to use the same email id at both places or add the one that is set for the repository as well to your GitHub account, in case you want your name to show up in the contributors' list. In case its intentional, please ignore. Just want to make sure that you are aware of it.

krankur avatar Nov 02 '19 07:11 krankur

No, I didn't know it worked like that. I was wondering why I didn't show up in the contributors list. GitHub does seem to identify those commits as mine. Weird.

Jazarro avatar Nov 02 '19 16:11 Jazarro

Yeah, even I had faced the same issue. But seems like you have updated your email id as the contributors count has gone up to 6 and it shows your name if you hover over the count. GitHub still doesn't show your name when on the contributors page though, which is strange. But it should show up there as well if you make any new commits now onward. At least that's what I observed in my case.

krankur avatar Nov 02 '19 17:11 krankur