shred icon indicating copy to clipboard operation
shred copied to clipboard

Consider committing lockfile

Open Imberflur opened this issue 2 years ago • 1 comments

In https://github.com/amethyst/shred/pull/228 I ran into the issue of the CI failing due to a dependency with a higher MSRV. If we had a lockfile to pin dependencies this would not have occurred.

Ideally, we would have CI running with both the pinned versions and without the lockfile. Since we already test with multiple compiler versions, I think it would be suitable to use a lockfile for the MSRV toolchain, and the others could ignore the lockfile.

Imberflur avatar Apr 23 '23 04:04 Imberflur

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Imberflur avatar Aug 29 '23 22:08 Imberflur