Crashes on failed assertion in Frames::wait_complete on Windows with Vulkan backend

[bonsairobo]

https://github.com/amethyst/rendy/blob/c3841966b387adf5e27b265b772b7f6c49e7a780/frame/src/frame.rs#L153

This happens on the first attempt at drawing a frame in my application that runs perfectly on Mac/Metal.

[zakarumych]

What value ready has?

[bonsairobo]

Err(DeviceLost(DeviceLost))

[zakarumych]

This is unfortunate. Device lost shouldn't typically happen, but we must handle it anyway.

[zakarumych]

Device lost probably caused by invalid memory access on gpu. So while rendy will propagate this error instead of panicking, you should fix what casusing it

[bonsairobo]

I'm not very experienced at debugging GPU problems, but I'm looking at my application with RenderDoc. It looks like I'm able to finish drawing 3 frames (which is the number of images in my swapchain). The last Vulkan API call made before crashing is vkQueuePresentKHR. I'd appreciate any help you could give me with debugging this.

[zakarumych]

The problem is not always manifests itself in renderdoc, until logical device become broken and DeviceLost error is returned.

Do you have validation layers available? They usually is able to catch problems that may cause loosing device.

You alos may ask help on amethyst discord rendering channel linking your code for review.

[bonsairobo]

The validation layer tells me that I wasn't properly aligning my uniform buffers. It's fixed now.

[zakarumych]

@bonsairobo glad you figured it out. But let make this open until this function panics on DeviceLost instead of returning error.