legion icon indicating copy to clipboard operation
legion copied to clipboard

Fix semver releasing

Open almindor opened this issue 5 years ago • 3 comments

Please stop releasing 0.2.x versions with breaking changes as cargo does "auto-update" even on full version locks.

E.g. if Cargo.toml contains legion = "0.2.1" a cargo update will switch to 0.2.4 which introduced breaking changes by removing resources from World as well as others.

v0.2.2 should've been a v0.3

almindor avatar Jun 23 '20 14:06 almindor

This would certainly be helpful, but technically, the semver specification does explicitly state that breaking changes may be introduced at any point under major version 0. Maybe cargo update is the problem here.

iwikal avatar Aug 26 '20 15:08 iwikal

Regardless of what the semver specs says, according to the cargo docs the minor version should be incremented when you break the public api for versions < 1.0.0 https://doc.rust-lang.org/cargo/reference/manifest.html#the-version-field

0x6273 avatar Aug 26 '20 17:08 0x6273

This would certainly be helpful, but technically, the semver specification does explicitly state that breaking changes may be introduced at any point under major version 0. Maybe cargo update is the problem here.

The entirety of the crates ecosystem increments the minor version for breaking changes when the major version is 0.

aloucks avatar Aug 27 '20 22:08 aloucks