bracket-lib icon indicating copy to clipboard operation
bracket-lib copied to clipboard

add serde to bracket-color for bevy

Open HexSleeves opened this issue 3 years ago • 3 comments

HexSleeves avatar Aug 03 '22 16:08 HexSleeves

That looks like a good idea. I wonder if it should be optional? Not everyone uses serde, and lots of people complain about its compile times. I'll try and look at this in the next day or two; the day-job is eating my time right now.

thebracket avatar Aug 03 '22 17:08 thebracket

Ah I didn't realize the long compile times with serde. In that case it should probably be a feature flag! I can bump that tonight for you

HexSleeves avatar Aug 03 '22 20:08 HexSleeves

Updaed to make serde a feature flag on bracket-bevy :)

HexSleeves avatar Aug 03 '22 23:08 HexSleeves

This looks good, and tested ok locally - so I'll go ahead and merge. Thanks!

thebracket avatar Oct 04 '22 13:10 thebracket