react-albus icon indicating copy to clipboard operation
react-albus copied to clipboard

Preserve query parameters when moving to next step

Open puopg opened this issue 7 years ago • 6 comments

When the Wizard is route controlled, when I move to the next step, the url and state changes.

Now this is all good, but the query parameters are lost during that transition. So for example, I wanted to move from add -> confirm, and my route has:

/basePath/add?itemId="thisisanid"

when I move to the next step my url becomes

/basePath/confirm", when I want the url to preserve the query param as /basePath/confirm?itemId="thisisanid"

Is there a way to do this?

puopg avatar Nov 29 '18 22:11 puopg

Are you not maintaining it in the state using redux or something?

sumanalapati avatar Apr 01 '19 22:04 sumanalapati

Well no I can do that, just since the interface for defining steps is strictly by name, an option to preserve query params when route controlled would be nice. Otherwise, routing is the form of navigation to move to steps within the wizard, and the next() method is cooler

puopg avatar Apr 01 '19 23:04 puopg

I just added a PR that tackles this issue, #43 .

skoshy avatar Aug 26 '19 14:08 skoshy

This issue is stale because it has been open 30 days with no activity. Remove no-issue-activity label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 07 '20 00:04 github-actions[bot]

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar May 09 '20 00:05 github-actions[bot]

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Aug 05 '23 00:08 github-actions[bot]