one-app-cli icon indicating copy to clipboard operation
one-app-cli copied to clipboard

Misleading error message when One App is killed

Open smackfu opened this issue 1 year ago • 1 comments

🐞 Bug Report

Describe the bug

When one-app is killed by SIGKILL, a message is printed that says "Error: Error running docker. Are you sure you have it installed?" This error message is not useful.

To Reproduce

Start one-app via one-app-runner, then stop the container.

...
error: still running after 10s, forcibly shutting down
error: shutting down, forcibly stopping node
<mydir>/node_modules/@americanexpress/one-app-runner/src/startApp.js:258
    throw new Error(
          ^

Error: Error running docker. Are you sure you have it installed? For installation and setup details see https://www.docker.com/products/docker-desktop
    at startApp (<mydir>/node_modules/@americanexpress/one-app-runner/src/startApp.js:258:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  [cause]: 137
}

Expected behavior

There is no need for an error to be printed here.

smackfu avatar Jan 16 '24 20:01 smackfu

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Feb 16 '24 00:02 github-actions[bot]