one-app-cli icon indicating copy to clipboard operation
one-app-cli copied to clipboard

one-app-bundler: eslint-loader is deprecated in favor of eslint-webpack-plugin

Open aorinevo opened this issue 1 year ago • 3 comments

💡 Feature request

Deprecate eslint-loader in favor of eslint-webpack-plugin.

A clear and concise description of what you want and what your use case is.

Example

Please include a basic code example of the new feature. Skip this section if not applicable.

My team is undertaking dependency management and as part of that, we are attempting to upgrade to latest eslint. In that process we came to identify that one-app-bundler relies on eslint-loader 4.0.2 which is incompatible with eslint ^8. This is blocking our adoption of eslint v8.

A clear and concise description of what you want to happen.

Replace eslint-loader package with its successor, eslint-webpack-plugin.

A clear and concise description of any alternative solutions or features you've considered.

One alternative is to force install eslint-loader at the root of our project, however, while this will allow for successful install it creates other issues in the build process. Other than that, I do not know of any tractable alternate solutions.

aorinevo avatar Oct 07 '23 23:10 aorinevo

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Nov 07 '23 00:11 github-actions[bot]

This is already underway in https://github.com/americanexpress/one-app-cli/pull/568 - https://github.com/americanexpress/one-app-cli/pull/568/files/888f13def5b817014155275b7f36a6ec56bf35ec..aa2c5a5ad7f279996b6ab733f777a43ccba0eb8b

Unfortunately when the migration was previously done it resulted in some unexpected breaking changes and had to be reverted.

JAdshead avatar Nov 20 '23 16:11 JAdshead

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Dec 21 '23 00:12 github-actions[bot]