jest-image-snapshot
jest-image-snapshot copied to clipboard
americanexpress
fix: issue #210
Issue results from max buffer size being fixed to 10MB. Replaced with maximum allowable memory so that it becomes the imperative of the user if the user performs tasks that cause an out of memory error. This behavior is then consistent with Node.JS, if they were to allocate an extraordinarily large Buffer exceeding the available memory in the system.
Can this be merged? It would be awesome to have this fix in the code, as I still constantly run into the error this PR would fix. Thank you. 🙏
This pull request is stale because it has been open 30 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can this be merged? It would be awesome to have this fix in the code, as I still constantly run into the error this PR would fix. Thank you.
Hey Lukas (@lukasoppermann), I thought these were accepted and merged months ago. Didn't mean to hold you up. If you can't get it directly from my git repository (https://github.com/omnisip/jest-image-snapshot), you can get them from @omnisip/jest-image-snapshot on npmjs. I've pushed a package that matches master with the changes intact.
Can this be merged? It would be awesome to have this fix in the code, as I still constantly run into the error this PR would fix. Thank you.
Hey Lukas (@lukasoppermann), I thought these were accepted and merged months ago. Didn't mean to hold you up. If you can't get it directly from my git repository (https://github.com/omnisip/jest-image-snapshot), you can get them from @omnisip/jest-image-snapshot on npmjs. I've pushed a package that matches master with the changes intact.
@omnisip Could you update this PR instead and that way everyone can benefit without needing a fork?
Can this be merged? It would be awesome to have this fix in the code, as I still constantly run into the error this PR would fix. Thank you.
Hey Lukas (@lukasoppermann), I thought these were accepted and merged months ago. Didn't mean to hold you up. If you can't get it directly from my git repository (https://github.com/omnisip/jest-image-snapshot), you can get them from @omnisip/jest-image-snapshot on npmjs. I've pushed a package that matches master with the changes intact.
@omnisip Could you update this PR instead and that way everyone can benefit without needing a fork?
For the last several months, about half of my week has been working on improving the performance of jest-image-snapshot and SSIM.js, and I've made tremendous progress. Changes to both Emscripten and LLVM have been made to make WebAssembly SIMD work efficiently even on current versions of Node.JS LTS (where V8 is months or years behind Chrome). For users of this project, that means they'll be able to take advantage of experimental WASM SIMD and Threading long before the standard is finalized. Even better, it will mean that they'll be able to complete all of the comparisons and snapshots in a fraction of the time. Barring uncontrollable snapshot delay from Chrome, it wouldn't be unreasonable to verify that a 1080p snapshot matches in less than 100ms if not 30 or 15.
Taking this into consideration with your legal team's request, it's like saying, "Hey, you may be working for free, and yeah, you're work might be valuable. But no, we don't think you deserve to be recognized for it."
@omnisip We are having the discussion with legal right now. I will keep you updated.
This pull request is stale because it has been open 30 days with no activity.
This pull request is stale because it has been open 30 days with no activity.
This pull request is stale because it has been open 30 days with no activity.