dsa.js-data-structures-algorithms-javascript icon indicating copy to clipboard operation
dsa.js-data-structures-algorithms-javascript copied to clipboard

Published 20 hours ago • verified publisher icon amejiarosario

Radix sort in javascript

Open AdithyaS99 opened this issue 2 years ago • 4 comments

I have added a new sorting algorithm, the radix sort to the repo. Please review this and approve. @amejiarosario please approve and merge. I would like to contribute to this.

AdithyaS99 avatar Nov 19 '21 12:11 AdithyaS99

Hi @AdithyaS99! Thanks for the contribution!

Could you please add some unit tests?

amejiarosario avatar Nov 19 '21 12:11 amejiarosario

@amejiarosario I have added a unit test.

AdithyaS99 avatar Nov 19 '21 14:11 AdithyaS99

For testing, you need to create a test file. Something similar to: https://github.com/amejiarosario/dsa.js-data-structures-algorithms-javascript/blob/master/src/algorithms/sorting/sorting.spec.js that you can run with npm test

amejiarosario avatar Nov 19 '21 18:11 amejiarosario

Hi @amejiarosario I have added a separate unit test file. Please do review and approve. Thank you so much!

AdithyaS99 avatar Nov 20 '21 06:11 AdithyaS99