behance icon indicating copy to clipboard operation
behance copied to clipboard

Relax constraints on faraday and faraday_middleware

Open utkarsh2102 opened this issue 5 years ago • 2 comments

Hi,

https://github.com/amedrz/behance/blob/0b4633c53b5af8eb9817178230bbf272e0486539/behance.gemspec#L20-L21

With faraday 1.1.0 and faraday_middleware 1.0.0, behance fails to build/work, only because of the ~> constraints. If it could be >= instead, that'd work great!


Here's a patch:

Author: Utkarsh Gupta <[email protected]>
Bug-Debian: https://bugs.debian.org/976160
Last-Update: 2020-11-30

--- a/behance.gemspec
+++ b/behance.gemspec
@@ -17,8 +17,8 @@
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_runtime_dependency     'faraday',            '~> 0.15'
-  gem.add_runtime_dependency     'faraday_middleware', '~> 0.12.2'
+  gem.add_runtime_dependency     'faraday',            '>= 0.15'
+  gem.add_runtime_dependency     'faraday_middleware', '>= 0.12.2'
   gem.add_runtime_dependency     'json',               '~> 2.1'
   gem.add_development_dependency 'webmock',            '~> 3.7'
   gem.add_development_dependency 'rspec',              '~> 3.8'

utkarsh2102 avatar Nov 30 '20 19:11 utkarsh2102

Hello @utkarsh2102, thanks for the heads up. Could you please make a PR for this? I'm happy to merge it afterwards.

amedrz avatar Dec 01 '20 16:12 amedrz

@amedrz not the original author but I prepared a PR

mknudsen avatar Apr 16 '22 16:04 mknudsen