Andrew Casey
Andrew Casey
CI failure seems likely to be addressed by https://github.com/dotnet/aspnetcore/pull/57269.
The difference appears to be in log output. If we can't make the assert more robust, we may just want to keep this on the helix retry list (even though...
Just noticed that this is a draft. Feel free to ignore my comments if they don't make sense yet.
CI failures look legit. Probably need some `#if`s.
> @amcasey, > > > CI failures look legit. Probably need some `#if`s. > > There was a name collision between `System.UriComponent` and `Microsoft.AspNetCore.Http.Extensions.UriHelper+UriComponent` (introduced in this PR) that I...
All good, @BrennanConroy?
You both know more about this than I do, but my outside opinion is that the perf looks about the same (between span and addref), so I'd pick whichever results...
Failures are https://github.com/dotnet/aspnetcore/issues/57416
Remaining failures are the known e2e issues in `release/8.0`.
Possibly related: https://github.com/dotnet/aspnetcore/issues/22831, https://github.com/dotnet/aspnetcore/issues/53894